Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(typescript-estree): correct AST regression introduced by TS4.0 upgrade #2316
I had a major brainfart when implementing #2305 and didn't think about the fact that changes should be backwards compatible.
When handling the null type change introduced by
We don't have automated testing against old TS versions yet (#1752) so I tested this by hand by doing the following:
Thanks for the PR, @bradzacher!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
@@ Coverage Diff @@ ## master #2316 +/- ## ========================================== - Coverage 93.10% 93.09% -0.02% ========================================== Files 283 284 +1 Lines 9081 9092 +11 Branches 2493 2495 +2 ========================================== + Hits 8455 8464 +9 - Misses 301 302 +1 - Partials 325 326 +1
Flags with carried forward coverage won't be shown. Click here to find out more.