Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-extra-parens] stop reporting on calling generic functions with one argument and type parameters containing parentheses #2319

Merged
merged 2 commits into from Jul 27, 2020

Conversation

cherryblossom000
Copy link
Contributor

@cherryblossom000 cherryblossom000 commented Jul 22, 2020

Fixes #2314

…ric functions with one argument and type parameters containing parentheses (fixes #2314)
@typescript-eslint
Copy link
Contributor

@typescript-eslint typescript-eslint bot commented Jul 22, 2020

Thanks for the PR, @cherryblossom000!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Jul 22, 2020

Codecov Report

Merging #2319 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2319   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files         284      284           
  Lines        9092     9097    +5     
  Branches     2495     2499    +4     
=======================================
+ Hits         8464     8469    +5     
  Misses        302      302           
  Partials      326      326           
Flag Coverage Δ
#unittest 93.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-extra-parens.ts 96.77% <100.00%> (+0.28%) ⬆️

@bradzacher bradzacher added the bug label Jul 22, 2020
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks!

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-extra-parens]: stop reporting on calling generic functions with one argument and type parameters containing parentheses fix(eslint-plugin): [no-extra-parens] stop reporting on calling generic functions with one argument and type parameters containing parentheses Jul 27, 2020
@bradzacher bradzacher merged commit 616a841 into typescript-eslint:master Jul 27, 2020
10 checks passed
@cherryblossom000 cherryblossom000 deleted the 2314 branch Jul 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
2 participants