Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-error` to `allow-with-description` #2351

Merged
merged 1 commit into from Aug 3, 2020

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented Aug 3, 2020

Fixes #2146

BREAKING CHANGE:

Default rule options is a breaking change.

…rror` to `allow-with-description`

Fixes #2146

BREAKING CHANGE:

Default rule options is a breaking change.
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Aug 3, 2020

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Aug 3, 2020

Codecov Report

Merging #2351 into v4 will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v4    #2351      +/-   ##
==========================================
- Coverage   92.97%   92.97%   -0.01%     
==========================================
  Files         285      285              
  Lines        9014     9013       -1     
  Branches     2510     2510              
==========================================
- Hits         8381     8380       -1     
  Misses        304      304              
  Partials      329      329              
Flag Coverage Δ
#unittest 92.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts 95.45% <ø> (-0.20%) ⬇️
@bradzacher bradzacher merged commit ef85b7b into v4 Aug 3, 2020
11 checks passed
11 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Publish the latest code as a v4 prerelease version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch Coverage not affected when comparing df37be2...1e68c46
Details
codecov/project 92.97% (+-0.01%) compared to df37be2
Details
@bradzacher bradzacher deleted the 2146-ban-types-defaults branch Aug 3, 2020
@bradzacher bradzacher linked an issue that may be closed by this pull request Aug 3, 2020
bradzacher added a commit that referenced this pull request Aug 3, 2020
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
bradzacher added a commit that referenced this pull request Aug 9, 2020
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
bradzacher added a commit that referenced this pull request Aug 10, 2020
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
bradzacher added a commit that referenced this pull request Aug 19, 2020
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
bradzacher added a commit that referenced this pull request Aug 29, 2020
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
bradzacher added a commit that referenced this pull request Aug 29, 2020
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant