fix(eslint-plugin): [return-await] don't error for `in-try-catch` if the return is in a `catch` without a `finally` #2356
Thanks for the PR, @soobing!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
@@ Coverage Diff @@ ## master #2356 +/- ## ========================================== + Coverage 92.81% 92.82% +0.01% ========================================== Files 290 290 Lines 9453 9481 +28 Branches 2647 2657 +10 ========================================== + Hits 8774 8801 +27 - Misses 322 323 +1 Partials 357 357
Flags with carried forward coverage won't be shown. Click here to find out more.
So the issue in question isn't that the code was erroring - it's that it shouldn't error.
The code should work in the following way for
bradzacher left a comment
The code LGTM.
Could you please update the docs for the
Specifically, could you make it very clear how it works, doing something like this will be good.
…the return is in a `catch` without a `finally` (typescript-eslint#2356)