Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): correct analysis of abstract class properties #2420

Merged
merged 1 commit into from Aug 24, 2020

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented Aug 24, 2020

Fixes #2417

Fixes #2417
@bradzacher bradzacher added the bug label Aug 24, 2020
@bradzacher bradzacher added this to the 4.0.0 milestone Aug 24, 2020
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Aug 24, 2020

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher linked an issue that may be closed by this pull request Aug 24, 2020
3 of 3 tasks complete
@codecov
Copy link

@codecov codecov bot commented Aug 24, 2020

Codecov Report

Merging #2420 into v4 will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##               v4    #2420   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files         288      288           
  Lines        9246     9247    +1     
  Branches     2572     2572           
=======================================
+ Hits         8594     8595    +1     
  Misses        320      320           
  Partials      332      332           
Flag Coverage Δ
#unittest 92.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/scope-manager/src/referencer/Referencer.ts 93.85% <100.00%> (+0.02%) ⬆️
@bradzacher bradzacher merged commit 719faa1 into v4 Aug 24, 2020
11 checks passed
11 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Publish the latest code as a v4 prerelease version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch 100.00% of diff hit (target 90.00%)
Details
codecov/project 92.94% (+0.00%) compared to c4f67a2
Details
@bradzacher bradzacher deleted the 2417-abstract-props-scope-analysis branch Aug 24, 2020
bradzacher added a commit that referenced this pull request Aug 29, 2020
)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant