Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-condition] correct regression with unary negations #2422

Merged
merged 1 commit into from Aug 25, 2020

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented Aug 25, 2020

Fixes #2421

…h unary negations

Fixes #2421
@bradzacher bradzacher added the bug label Aug 25, 2020
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Aug 25, 2020

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Aug 25, 2020

Codecov Report

Merging #2422 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2422      +/-   ##
==========================================
+ Coverage   93.12%   93.16%   +0.04%     
==========================================
  Files         287      287              
  Lines        9189     9186       -3     
  Branches     2530     2528       -2     
==========================================
+ Hits         8557     8558       +1     
+ Misses        302      301       -1     
+ Partials      330      327       -3     
Flag Coverage Δ
#unittest 93.16% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.26% <100.00%> (+2.24%) ⬆️
@bradzacher bradzacher merged commit d1f0887 into master Aug 25, 2020
10 checks passed
10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch 100.00% of diff hit (target 90.00%)
Details
codecov/project 93.16% (+0.04%) compared to 50f9c4a
Details
@bradzacher bradzacher deleted the 2421-unnec-cond-unary-negation branch Aug 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant