Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [typedef] false positive for rest parameter with array destructuring #2441

merged 1 commit into from Sep 6, 2020


Copy link

@gaonK gaonK commented Aug 30, 2020

Fixes #2433

Copy link

@typescript-eslint typescript-eslint bot commented Aug 30, 2020

Thanks for the PR, @gaonK!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

@codecov codecov bot commented Aug 30, 2020

Codecov Report

Merging #2441 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2441      +/-   ##
- Coverage   92.94%   92.93%   -0.01%     
  Files         289      289              
  Lines        9272     9275       +3     
  Branches     2583     2585       +2     
+ Hits         8618     8620       +2     
  Misses        320      320              
- Partials      334      335       +1     
Flag Coverage Δ
#unittest 92.93% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/typedef.ts 96.05% <66.66%> (-1.21%) ⬇️
@bradzacher bradzacher added the bug label Sep 2, 2020
Copy link

@bradzacher bradzacher left a comment

ezpz thanks!

@bradzacher bradzacher changed the title fix(eslint-plugin): [typedef] do not report when rest parameter has own type annotation fix(eslint-plugin): [typedef] false positive for rest parameter with array destructuring Sep 6, 2020
@bradzacher bradzacher merged commit 2ada5af into typescript-eslint:master Sep 6, 2020
9 of 11 checks passed
9 of 11 checks passed
Unit tests Unit tests
Code style and lint
Run integration tests on primary Node.js version
Run unit tests on other Node.js versions (10.x)
Run unit tests on other Node.js versions (14.x)
Publish the latest code as a canary version
Publish the latest code as a v4 prerelease version
Semantic Pull Request PR has only one non-merge commit and it's not semantic; add another commit before squashing
codecov/patch 66.66% of diff hit (target 90.00%)
codecov/project 92.93% (+-0.01%) compared to 4ff8c43
phaux added a commit to phaux/typescript-eslint that referenced this pull request Sep 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.