Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): handle missing message IDs in eslint v5/v6 #2461

Merged

Conversation

@esetnik
Copy link
Contributor

@esetnik esetnik commented Sep 1, 2020

Fixes #2451

esetnik added 2 commits Sep 1, 2020
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Sep 1, 2020

Thanks for the PR, @esetnik!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@esetnik esetnik marked this pull request as ready for review Sep 1, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 1, 2020

Codecov Report

Merging #2461 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2461      +/-   ##
==========================================
- Coverage   92.94%   92.83%   -0.12%     
==========================================
  Files         289      289              
  Lines        9272     9283      +11     
  Branches     2583     2594      +11     
==========================================
  Hits         8618     8618              
  Misses        320      320              
- Partials      334      345      +11     
Flag Coverage Δ
#unittest 92.83% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/indent.ts 90.47% <0.00%> (-2.21%) ⬇️
...kages/eslint-plugin/src/rules/init-declarations.ts 76.47% <0.00%> (-4.78%) ⬇️
...ackages/eslint-plugin/src/rules/keyword-spacing.ts 92.85% <0.00%> (-7.15%) ⬇️
...nt-plugin/src/rules/lines-between-class-members.ts 85.71% <0.00%> (-6.60%) ⬇️
...ackages/eslint-plugin/src/rules/no-invalid-this.ts 95.45% <0.00%> (-4.55%) ⬇️
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts 80.76% <0.00%> (-1.59%) ⬇️
...s/eslint-plugin/src/rules/no-unused-expressions.ts 88.88% <0.00%> (-5.23%) ⬇️
packages/eslint-plugin/src/rules/no-unused-vars.ts 95.38% <0.00%> (-1.50%) ⬇️
.../eslint-plugin/src/rules/no-useless-constructor.ts 95.23% <0.00%> (-4.77%) ⬇️
packages/eslint-plugin/src/rules/quotes.ts 88.88% <0.00%> (-5.23%) ⬇️
... and 1 more
@esetnik esetnik changed the title Eslint v6 Messages Compatibility fix(eslint-plugin): eslint v6 messages compatibility Sep 1, 2020
@bradzacher bradzacher added the bug label Sep 1, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Just went through and double checked all the rules. Theres a small number you can revert as they have had message ids since pre v5.

The rest are good. Thanks for doing this!

@bradzacher bradzacher changed the title fix(eslint-plugin): eslint v6 messages compatibility fix(eslint-plugin): handle missing message IDs in eslint v5/v6 Sep 1, 2020
@bradzacher
Copy link
Member

@bradzacher bradzacher commented Sep 1, 2020

missed a few of the v4 ones - the comments are (annoyingly) hidden under the fold by github

@esetnik esetnik requested a review from bradzacher Sep 1, 2020
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for doing this!

@bradzacher bradzacher merged commit ffdfade into typescript-eslint:master Sep 1, 2020
9 of 10 checks passed
9 of 10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
codecov/patch Codecov Report
Details
Semantic Pull Request ready to be squashed
Details
codecov/project Codecov Report
Details
phaux added a commit to phaux/typescript-eslint that referenced this pull request Sep 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants