fix(eslint-plugin): handle missing message IDs in eslint v5/v6 #2461
Conversation
Thanks for the PR, @esetnik! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! |
Codecov Report
@@ Coverage Diff @@
## master #2461 +/- ##
==========================================
- Coverage 92.94% 92.83% -0.12%
==========================================
Files 289 289
Lines 9272 9283 +11
Branches 2583 2594 +11
==========================================
Hits 8618 8618
Misses 320 320
- Partials 334 345 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Just went through and double checked all the rules. Theres a small number you can revert as they have had message ids since pre v5. The rest are good. Thanks for doing this! |
missed a few of the v4 ones - the comments are (annoyingly) hidden under the fold by github |
LGTM - thanks for doing this! |
ffdfade
into
typescript-eslint:master
Fixes #2451