Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): fallback to lib 'esnext' or 'es5' when ecma version is unsupported #2474

Merged
merged 3 commits into from Sep 3, 2020

Conversation

@gcangussu
Copy link
Contributor

@gcangussu gcangussu commented Sep 2, 2020

Fixes #2468

  • Test on real code base
  • Write automated tests
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Sep 2, 2020

Thanks for the PR, @gcangussu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug label Sep 2, 2020
@bradzacher bradzacher changed the title fix(parser): fallback to lib 'esnext' or 'es5' when ecma version is unsupported fix(scope-manager): fallback to lib 'esnext' or 'es5' when ecma version is unsupported Sep 2, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 2, 2020

Codecov Report

Merging #2474 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2474      +/-   ##
==========================================
+ Coverage   92.80%   92.82%   +0.02%     
==========================================
  Files         289      289              
  Lines        9294     9294              
  Branches     2599     2600       +1     
==========================================
+ Hits         8625     8627       +2     
+ Misses        322      321       -1     
+ Partials      347      346       -1     
Flag Coverage Δ
#unittest 92.82% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/analyze.ts 76.92% <100.00%> (+7.69%) ⬆️
@gcangussu gcangussu marked this pull request as ready for review Sep 2, 2020
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for doing this

@bradzacher bradzacher merged commit 20a7dcc into typescript-eslint:master Sep 3, 2020
10 checks passed
10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
@gcangussu gcangussu deleted the gcangussu:fix-es2021 branch Sep 3, 2020
phaux added a commit to phaux/typescript-eslint that referenced this pull request Sep 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants