Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-invalid-void-type] add option to allow `this: void` #2481

Merged
merged 6 commits into from Sep 28, 2020

Conversation

@tadhgmister
Copy link
Contributor

@tadhgmister tadhgmister commented Sep 3, 2020

Fixes: #2148

adds option to allow using a this parameter to void, while I'd like to set it enabled by default that would complicate the test cases since it changes most of the error messages so I left it disabled by default.

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Sep 3, 2020

Thanks for the PR, @tadhgmister!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Sep 3, 2020

Codecov Report

Merging #2481 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2481   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         292      292           
  Lines        9571     9578    +7     
  Branches     2680     2686    +6     
=======================================
+ Hits         8885     8892    +7     
  Misses        324      324           
  Partials      362      362           
Flag Coverage Δ
#unittest 92.83% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-invalid-void-type.ts 95.34% <ø> (+0.90%) ⬆️
Copy link
Member

@bradzacher bradzacher left a comment

lgtm - thanks for your contribution.
one comment on the docs

@bradzacher bradzacher changed the title feat[eslint-plugin]: [no-invalid-void-type] add option to allow this: void feat(eslint-plugin): [no-invalid-void-type] add option to allow this: void Sep 21, 2020
@bradzacher bradzacher changed the title feat(eslint-plugin): [no-invalid-void-type] add option to allow this: void feat(eslint-plugin): [no-invalid-void-type] add option to allow `this: void` Sep 21, 2020
tadhgmister pushed a commit to tadhgmister/typescript-eslint that referenced this pull request Sep 21, 2020
tadhgmister pushed a commit to tadhgmister/typescript-eslint that referenced this pull request Sep 21, 2020
@tadhgmister
Copy link
Contributor Author

@tadhgmister tadhgmister commented Sep 24, 2020

Based on this response I'd like one reconsider if you want me to change the wording, if you still think the word "recommends" is too strong I'll change it but I really think the docs as I wrote it is the correct way of phrasing it.

@tadhgmister tadhgmister requested a review from bradzacher Sep 24, 2020
tadhgmister added 3 commits Sep 24, 2020
tadhgmister added 2 commits Sep 28, 2020
incorperate review.
Copy link
Member

@bradzacher bradzacher left a comment

Thanks for your contribution!

@bradzacher bradzacher merged commit ddf5660 into typescript-eslint:master Sep 28, 2020
10 checks passed
10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
@tadhgmister tadhgmister deleted the tadhgmister:thisVoidFix branch Sep 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants