Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): correctly handle inferred types in nested type scopes #2497

Merged
merged 1 commit into from Sep 6, 2020

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented Sep 6, 2020

Fixes #2459

This was a bit tricky. Nested scopes are wack.

…opes

Fixes #2459

This was a bit tricky. Nested scopes are wack.
@bradzacher bradzacher added the bug label Sep 6, 2020
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Sep 6, 2020

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Sep 6, 2020

Codecov Report

Merging #2497 into master will decrease coverage by 0.00%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #2497      +/-   ##
==========================================
- Coverage   92.83%   92.82%   -0.01%     
==========================================
  Files         290      290              
  Lines        9377     9393      +16     
  Branches     2626     2631       +5     
==========================================
+ Hits         8705     8719      +14     
- Misses        321      322       +1     
- Partials      351      352       +1     
Flag Coverage Δ
#unittest 92.82% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/scope-manager/src/referencer/TypeVisitor.ts 89.01% <87.50%> (-0.33%) ⬇️
@bradzacher bradzacher merged commit 95f6bf4 into master Sep 6, 2020
9 of 10 checks passed
9 of 10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
codecov/patch Codecov Report
Details
Semantic Pull Request ready to be squashed
Details
codecov/project Codecov Report
Details
@bradzacher bradzacher deleted the 2459-infer branch Sep 6, 2020
phaux added a commit to phaux/typescript-eslint that referenced this pull request Sep 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant