Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): add `const` as a global type variable #2499

Merged
merged 1 commit into from Sep 6, 2020

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented Sep 6, 2020

Handles part of #2477

Unrelated, but I cleaned up some useless cruft from the lib at the same time.

@bradzacher bradzacher added the bug label Sep 6, 2020
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Sep 6, 2020

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher force-pushed the 2477-const-global-type branch 2 times, most recently from 47b8e4f to 46c6a43 Sep 6, 2020
Handles part of #2477
@bradzacher bradzacher force-pushed the 2477-const-global-type branch from 46c6a43 to d8c3528 Sep 6, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 6, 2020

Codecov Report

Merging #2499 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2499   +/-   ##
=======================================
  Coverage   92.80%   92.81%           
=======================================
  Files         290      290           
  Lines        9429     9430    +1     
  Branches     2638     2638           
=======================================
+ Hits         8751     8752    +1     
  Misses        323      323           
  Partials      355      355           
Flag Coverage Δ
#unittest 92.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/dom.iterable.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/dom.ts 100.00% <ø> (ø)
...ackages/scope-manager/src/lib/es2015.collection.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.core.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.generator.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.iterable.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.promise.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.proxy.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.reflect.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.symbol.ts 100.00% <ø> (ø)
... and 32 more
@bradzacher bradzacher merged commit eb3f6e3 into master Sep 6, 2020
10 checks passed
10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
@bradzacher bradzacher deleted the 2477-const-global-type branch Sep 6, 2020
@bradzacher bradzacher mentioned this pull request Sep 14, 2020
3 of 3 tasks complete
phaux added a commit to phaux/typescript-eslint that referenced this pull request Sep 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant