Skip to content

/ typescript-eslint

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [no-use-before-define] false positive with jsx pragma reference #2503

Merged
merged 1 commit into from Sep 6, 2020
Merged

fix(eslint-plugin): [no-use-before-define] false positive with jsx pragma reference #2503

merged 1 commit into from Sep 6, 2020
+54 −1

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented Sep 6, 2020

Fixes #2502
@bradzacher
fix(eslint-plugin): [no-use-before-define] false positive with jsx pr…
Verified
This commit was signed with a verified signature.
bradzacher Brad Zacher
GPG key ID: 9132184EA9C3AF39 Learn about signing commits
Loading status checks…
00450e9 
…agma reference

Fixes #2502
@bradzacher bradzacher added the bug label Sep 6, 2020
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Sep 6, 2020

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.
@bradzacher bradzacher merged commit 5afeeab into master Sep 6, 2020
10 checks passed
10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
@bradzacher bradzacher deleted the 2502-jsx-no-use-before-define branch Sep 6, 2020
phaux added a commit to phaux/typescript-eslint that referenced this pull request Sep 28, 2020
@bradzacher @phaux
fix(eslint-plugin): [no-use-before-define] false positive with jsx pr…
387b0ef 
…agma reference (typescript-eslint#2503)

Fixes typescript-eslint#2502
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

[no-use-before-define] `import * as React` marked as error in TSX/JSX file
1 participant
@bradzacher