Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [naming-convention] ignore properties inside object patterns #2566

Conversation

@JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 15, 2020

"'Do it! Do it now!' - Arnold Schwarzenegger" - Brad Zacher

Starts on #2244. Doesn't add the new rule options for more specific properties, but does ensure that object destructures only match on variables -- not properties.

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Sep 15, 2020

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug label Sep 15, 2020
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review Sep 15, 2020
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks!

@bradzacher bradzacher merged commit 53a3cbc into typescript-eslint:master Sep 21, 2020
10 checks passed
10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
@JoshuaKGoldberg JoshuaKGoldberg deleted the JoshuaKGoldberg:naming-convention-object-patterns-variables-only branch Sep 21, 2020
phaux added a commit to phaux/typescript-eslint that referenced this pull request Sep 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants