Join GitHub today
feat(eslint-plugin): allow explicit variable type with arrow functions #260
@@ Coverage Diff @@ ## master #260 +/- ## ========================================== + Coverage 97.24% 97.24% +<.01% ========================================== Files 67 67 Lines 2357 2361 +4 Branches 336 338 +2 ========================================== + Hits 2292 2296 +4 Misses 44 44 Partials 21 21
bradzacher left a comment
Please add an example to the rule's readme so people can see this functionality without looking at the tests.
@typescript-eslint/core-team do we want to put this behind a setting (default on) in case people don't want to "trust" type annotations?
type X = Function; const x: X = () => 1;
Thanks for the review @bradzacher .
I think you are right. I made this opt-in.
Feb 14, 2019
Please avoid the workflow of amend + force push.
@bradzacher I didn't realize GitHub couldn't handle this properly. Also, I'm not very used to commitlint and was unsure what commit messages I should use for non-features commits. I'll do my best to avoid force-pushes in the future. All my apologies for the inconvenience and thanks for your time and review.