Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-duplicate-imports] distinguish member, default #2637

Merged
merged 1 commit into from Oct 6, 2020

Conversation

@yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Oct 6, 2020

fixes #2636
And also fixes typo - review. thanks @ginger-kang

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Oct 6, 2020

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Oct 6, 2020

Codecov Report

Merging #2637 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2637   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files         294      294           
  Lines        9657     9664    +7     
  Branches     2709     2711    +2     
=======================================
+ Hits         8966     8973    +7     
  Misses        326      326           
  Partials      365      365           
Flag Coverage Δ
#unittest 92.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-duplicate-imports.ts 97.77% <ø> (+0.40%) ⬆️
Copy link
Member

@bradzacher bradzacher left a comment

lgtm - thanks for this!

@bradzacher bradzacher merged commit c71f423 into typescript-eslint:master Oct 6, 2020
10 checks passed
10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.