Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
feat(eslint-plugin): [prefer-readonly-parameter-types] add `ignoreInferredTypes` option #2668
This PR addresses part of #2079. I'm not sure whether I should mark this as
This introduces an
…Types option Allows `prefer-readonly-parameter-types` users to specify an `ignoreInferredTypes` option, which if true will ignroe errors on parameters with no explicit type parameter. This may be useful for cases where an external dependency specifies mutable parameter types, e.g. for parameters in callbacks.
Thanks for the PR, @eyelidlessness!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
@@ Coverage Diff @@ ## master #2668 +/- ## ======================================= Coverage 92.83% 92.83% ======================================= Files 294 294 Lines 9666 9669 +3 Branches 2711 2712 +1 ======================================= + Hits 8973 8976 +3 Misses 327 327 Partials 366 366
Flags with carried forward coverage won't be shown. Click here to find out more.
Okay, so I was looking at the code coverage report to try to see why it was such a significant reduction, and... discovered that not only had I implemented this incorrectly... I also had gotten false positives in the tests because apparently