Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-type-assertion] correct fixer for vue files #2680

Merged
merged 3 commits into from Oct 18, 2020

Conversation

@thomasmichaelwallace
Copy link
Contributor

@thomasmichaelwallace thomasmichaelwallace commented Oct 16, 2020

Fixes #2591

n.b. I've kept this fix tight, because I had some whitespace artefacts using node vs originalNode. If you think I should extend it to the rest of the file, or have some guidance of dealing with how node ranges don't quite match the originalNode.end values, let me know.

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Oct 16, 2020

Thanks for the PR, @thomasmichaelwallace!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug label Oct 16, 2020
Copy link
Member

@bradzacher bradzacher left a comment

awesome - even went the extra mile with an integration test.
Thanks heaps for this!

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-unnecessary-type-assertion] fixer support for vue fix(eslint-plugin): [no-unnecessary-type-assertion] correct fixer for vue files Oct 18, 2020
@bradzacher bradzacher merged commit 55111af into typescript-eslint:master Oct 18, 2020
10 checks passed
10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch Coverage not affected when comparing 90a5878...d9d6a7e
Details
codecov/project 92.78% (+0.00%) compared to 90a5878
Details
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.