Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-misused-promises] False negative in LogicalExpression #2682

Conversation

@jsone-studios
Copy link
Contributor

@jsone-studios jsone-studios commented Oct 16, 2020

Fix #2544

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Oct 16, 2020

Thanks for the PR, @jsone-studios!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Oct 16, 2020

Codecov Report

Merging #2682 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2682   +/-   ##
=======================================
  Coverage   92.78%   92.79%           
=======================================
  Files         294      294           
  Lines        9676     9686   +10     
  Branches     2713     2717    +4     
=======================================
+ Hits         8978     8988   +10     
  Misses        330      330           
  Partials      368      368           
Flag Coverage Δ
#unittest 92.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts 100.00% <100.00%> (ø)
@jsone-studios jsone-studios force-pushed the jsone-studios:issue-2544-no-misused-promises branch from 7ac0db0 to e779ed2 Oct 16, 2020
@bradzacher bradzacher added the bug label Oct 16, 2020
Copy link
Member

@bradzacher bradzacher left a comment

great work! LGTM
thanks for fixing this.

@bradzacher bradzacher merged commit 30a6951 into typescript-eslint:master Oct 18, 2020
8 checks passed
8 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
@jsone-studios jsone-studios deleted the jsone-studios:issue-2544-no-misused-promises branch Oct 18, 2020
@LeandroDG
Copy link

@LeandroDG LeandroDG commented Oct 19, 2020

Thank you so much! :-)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.