Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [method-signature-style] correct fixer for overloads in an object literal type #2708

Merged
merged 1 commit into from Oct 25, 2020

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Oct 25, 2020

Fixes #2706

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Oct 25, 2020

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug label Oct 25, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 25, 2020

Codecov Report

Merging #2708 into master will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
- Coverage   92.78%   92.76%   -0.02%     
==========================================
  Files         295      295              
  Lines        9712     9716       +4     
  Branches     2725     2727       +2     
==========================================
+ Hits         9011     9013       +2     
  Misses        331      331              
- Partials      370      372       +2     
Flag Coverage Δ
#unittest 92.76% <57.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts 87.20% <57.14%> (-1.82%) ⬇️
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for fixing this!

@bradzacher bradzacher changed the title fix(eslint-plugin): [method-signature-style] handle LiteralType fix(eslint-plugin): [method-signature-style] correct fixer for overloads in an object literal type Oct 25, 2020
@bradzacher bradzacher merged commit 0763913 into typescript-eslint:master Oct 25, 2020
9 of 10 checks passed
9 of 10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
codecov/patch 57.14% of diff hit (target 90.00%)
Details
Semantic Pull Request ready to be squashed
Details
codecov/project 92.76% (+-0.02%) compared to 343d20d
Details
This was referenced Oct 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.