Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [consistent-indexed-object-style] fix wrong autofix behaviour with generics #2722

Merged
merged 1 commit into from Nov 1, 2020

Conversation

@timozander
Copy link
Contributor

@timozander timozander commented Oct 29, 2020

Fixes #2712

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Oct 29, 2020

Thanks for the PR, @timozander!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Oct 29, 2020

Codecov Report

Merging #2722 into master will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #2722      +/-   ##
==========================================
- Coverage   92.75%   92.74%   -0.01%     
==========================================
  Files         296      296              
  Lines        9739     9743       +4     
  Branches     2733     2735       +2     
==========================================
+ Hits         9033     9036       +3     
  Misses        332      332              
- Partials      374      375       +1     
Flag Coverage Δ
#unittest 92.74% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/consistent-indexed-object-style.ts 88.88% <80.00%> (-1.36%) ⬇️
@bradzacher bradzacher added the bug label Oct 29, 2020
@bradzacher bradzacher changed the title fix(eslint-plugin): fix wrong autofix behaviour with generics fix(eslint-plugin): [consistent-indexed-object-style] fix wrong autofix behaviour with generics Nov 1, 2020
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for your contribution!

@bradzacher bradzacher merged commit 73d9713 into typescript-eslint:master Nov 1, 2020
8 checks passed
8 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
@timozander timozander deleted the timozander:fix_2712 branch Nov 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants