Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-shadow] ignore global module augmentation #2729

merged 1 commit into from Nov 1, 2020


Copy link

@cherryblossom000 cherryblossom000 commented Nov 1, 2020

Fixes #2724

Copy link

@typescript-eslint typescript-eslint bot commented Nov 1, 2020

Thanks for the PR, @cherryblossom000!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

@codecov codecov bot commented Nov 1, 2020

Codecov Report

Merging #2729 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2729   +/-   ##
  Coverage   92.75%   92.75%           
  Files         296      296           
  Lines        9739     9744    +5     
  Branches     2733     2735    +2     
+ Hits         9033     9038    +5     
  Misses        332      332           
  Partials      374      374           
Flag Coverage Δ
unittest 92.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-shadow.ts 94.04% <100.00%> (+0.37%) ⬆️
@bradzacher bradzacher added the bug label Nov 1, 2020
Copy link

@bradzacher bradzacher left a comment


@bradzacher bradzacher changed the title fix(eslint-plugin): [no-shadow] ignore module augmentation fix(eslint-plugin): [no-shadow] ignore global module augmentation Nov 1, 2020
@bradzacher bradzacher merged commit d8c67a5 into typescript-eslint:master Nov 1, 2020
10 checks passed
10 checks passed
Unit tests Unit tests
Code style and lint
Run integration tests on primary Node.js version
Run unit tests on other Node.js versions (10.x)
Run unit tests on other Node.js versions (14.x)
Publish the latest code as a canary version
Semantic Pull Request ready to be squashed
codecov/patch 100.00% of diff hit (target 90.00%)
codecov/project 92.75% (+0.00%) compared to 5de6614
@cherryblossom000 cherryblossom000 deleted the cherryblossom000:2724 branch Nov 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants