Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TS4.1 features #2748

Merged
merged 1 commit into from Nov 8, 2020
Merged

feat: support TS4.1 features #2748

merged 1 commit into from Nov 8, 2020

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented Nov 8, 2020

Fixes #2583

  • Adds AST for Key Remapping in Mapped Types and Template Literal Types
  • Adds visitor keys for the above
  • Adds scope manager support for the above (just tests were required as it all is pretty simple)
  • Regenerates the scope-manager lib types
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Nov 8, 2020

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher force-pushed the ts-4_1-ast branch 2 times, most recently from a1f4c3e to 3d02928 Nov 8, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 8, 2020

Codecov Report

Merging #2748 (c2c1eb8) into master (e82698c) will increase coverage by 0.00%.
The diff coverage is 94.73%.

@@           Coverage Diff           @@
##           master    #2748   +/-   ##
=======================================
  Coverage   92.79%   92.80%           
=======================================
  Files         297      300    +3     
  Lines        9833     9849   +16     
  Branches     2762     2765    +3     
=======================================
+ Hits         9125     9140   +15     
  Misses        332      332           
- Partials      376      377    +1     
Flag Coverage Δ
unittest 92.80% <94.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/all.ts 100.00% <ø> (ø)
...src/configs/recommended-requiring-type-checking.ts 100.00% <ø> (ø)
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 93.75% <ø> (ø)
...ackages/eslint-plugin/src/rules/no-invalid-this.ts 95.83% <ø> (ø)
...ckages/eslint-plugin/src/rules/no-throw-literal.ts 95.00% <ø> (ø)
packages/scope-manager/src/lib/dom.iterable.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/dom.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.iterable.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es5.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/webworker.ts 100.00% <ø> (ø)
... and 13 more
Fixes #2583

- Adds AST for Key Remapping in Mapped Types and Template Literal Types
- Adds visitor keys for the above
- Adds scope manager support for the above (just tests were required as it all is pretty simple)
- Regenerates the scope-manager lib types
@bradzacher bradzacher force-pushed the ts-4_1-ast branch from 3d02928 to 4c459fc Nov 8, 2020
@bradzacher bradzacher merged commit 2be354b into master Nov 8, 2020
8 checks passed
8 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
@bradzacher bradzacher deleted the ts-4_1-ast branch Nov 8, 2020
@sosukesuzuki sosukesuzuki mentioned this pull request Nov 9, 2020
13 of 13 tasks complete
@sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Nov 9, 2020

@bradzacher Hi, Thanks for implementing this PR! Could you tell me when typescript-eslint/typescript-estree with TS 4.1 support will be released? We are now considering whether to include TS 4.1 support in the next minor version of Prettier.

@bradzacher
Copy link
Member Author

@bradzacher bradzacher commented Nov 9, 2020

Same all of our releases!
Monday 10am PST

@sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Nov 9, 2020

Okay, Thank you!

trivikr added a commit to trivikr/typescript-eslint that referenced this pull request Nov 24, 2020
The support for TS 4.1 features was added in typescript-eslint#2748
bradzacher pushed a commit that referenced this pull request Nov 24, 2020
The support for TS 4.1 features was added in #2748
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants