Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unsafe-member-access] ignore MemberExpression's whose parents are either TSClassImplements or TSInterfaceHeritage #2753

Merged
merged 3 commits into from Nov 11, 2020

Conversation

@hsmitty93
Copy link
Contributor

@hsmitty93 hsmitty93 commented Nov 11, 2020

Fixes #2740

  • I feel like the selector is too long to be on one line, but it wouldn't work if I split it. Any recommendations to shorten it? Or is it good to go like it is.
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Nov 11, 2020

Thanks for the PR, @hsmitty93!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug label Nov 11, 2020
Copy link
Member

@bradzacher bradzacher left a comment

great work! the idea and tests LGTM.

But I think we can make the selector a little easier on the eyes :)

hsmitty93 added 2 commits Nov 11, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Thanks for your contribution!

@bradzacher bradzacher merged commit 535db3b into typescript-eslint:master Nov 11, 2020
8 checks passed
8 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
@hsmitty93 hsmitty93 deleted the hsmitty93:fix-namespace-error branch Nov 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.