Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-condition] false positive when array predicate returns unknown #2772

Merged
merged 2 commits into from Nov 17, 2020

Conversation

@ArnaudBarre
Copy link
Contributor

@ArnaudBarre ArnaudBarre commented Nov 17, 2020

Fix: Mark unknown and any as possibly falsy.

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Nov 17, 2020

Thanks for the PR, @ArnaudBarre!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

…y-condition when predicate returns unknown
@codecov
Copy link

@codecov codecov bot commented Nov 17, 2020

Codecov Report

Merging #2772 (2a4e958) into master (3333040) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2772   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files         300      300           
  Lines        9852     9854    +2     
  Branches     2767     2767           
=======================================
+ Hits         9143     9145    +2     
  Misses        332      332           
  Partials      377      377           
Flag Coverage Δ
unittest 92.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 97.17% <100.00%> (+0.03%) ⬆️
@ArnaudBarre ArnaudBarre requested a review from bradzacher Nov 17, 2020
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks!

@bradzacher bradzacher changed the title fix(eslint-plugin): false positive alwaysTruthyFunc for no-unnecessary-condition when predicate returns unknown fix(eslint-plugin): [no-unnecessary-condition] false positive when array predicate returns unknown Nov 17, 2020
@bradzacher bradzacher merged commit 111c244 into typescript-eslint:master Nov 17, 2020
10 checks passed
10 checks passed
Typecheck Typecheck
Details
Unit tests Unit tests
Details
Code style and lint Code style and lint
Details
Run integration tests on primary Node.js version Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x) Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x) Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch 100.00% of diff hit (target 90.00%)
Details
codecov/project 92.80% (+0.00%) compared to 3333040
Details
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants