Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [prefer-literal-enum-member] allow pure template literal strings #2786

Conversation

@ddubrava
Copy link
Contributor

@ddubrava ddubrava commented Nov 19, 2020

fixes #2785

…al without expressions
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Nov 19, 2020

Thanks for the PR, @ddubrava!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug label Nov 19, 2020
Copy link
Member

@bradzacher bradzacher left a comment

x

@codecov
Copy link

@codecov codecov bot commented Nov 19, 2020

Codecov Report

Merging #2786 (45bb6f6) into master (e82698c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2786   +/-   ##
=======================================
  Coverage   92.79%   92.80%           
=======================================
  Files         297      300    +3     
  Lines        9833     9857   +24     
  Branches     2762     2769    +7     
=======================================
+ Hits         9125     9148   +23     
  Misses        332      332           
- Partials      376      377    +1     
Flag Coverage Δ
unittest 92.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...int-plugin/src/rules/prefer-literal-enum-member.ts 100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/array-type.ts 97.33% <0.00%> (-1.30%) ⬇️
packages/scope-manager/src/lib/index.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2020.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/esnext.ts 100.00% <0.00%> (ø)
packages/visitor-keys/src/visitor-keys.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 93.75% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-throw-literal.ts 95.00% <0.00%> (ø)
...eslint-plugin/src/rules/no-unsafe-member-access.ts 100.00% <0.00%> (ø)
... and 6 more
@bradzacher bradzacher changed the title fix(eslint-plugin): [prefer-literal-enum-member] ignore TemplateLiteral without expressions fix(eslint-plugin): [prefer-literal-enum-member] allow pure template literal strings Nov 19, 2020
@bradzacher bradzacher merged commit f3bf6a1 into typescript-eslint:master Nov 19, 2020
10 checks passed
10 checks passed
Typecheck Typecheck
Details
Unit tests Unit tests
Details
Code style and lint Code style and lint
Details
Run integration tests on primary Node.js version Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x) Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x) Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch 100.00% of diff hit (target 90.00%)
Details
codecov/project 92.80% (+0.00%) compared to e82698c
Details
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants