fix(typescript-estree): add default value for parserOptions.projectFolderIgnoreList and deduplicate resolved projects
#2819
Conversation
…olderIgnoreList` and deduplicate resolved projects In #2418 I introduced a regression - I forgot to add in the default value for `projectFolderIgnoreList`. This means that globs have been matching `node_modules` since the v4.0 release! Oops :( This PR fixes that. It also hoists the tsconfig path canonicalisation up so that we can deduplicate early. Previously if you provided a config like `projects: ['./tsconfig.json', './**/tsconfig.json']`, then we would resolve this to `./tsconfig.json` and `tsconfig.json`, then later canonicalise them. This meant we'd check that same tsconfig twice! By hoisting the canonicalisation, we can deduplicate this early. Fixes #2814
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2819 +/- ##
==========================================
- Coverage 92.74% 92.74% -0.01%
==========================================
Files 309 309
Lines 10320 10317 -3
Branches 2920 2920
==========================================
- Hits 9571 9568 -3
Misses 346 346
Partials 403 403
Flags with carried forward coverage won't be shown. Click here to find out more.
|
In #2418 I introduced a regression - I forgot to add in the default value for
projectFolderIgnoreList.This means that globs have been matching
node_modulessince the v4.0 release! Oops :(This PR fixes that.
It also hoists the tsconfig path canonicalisation up so that we can deduplicate early.
Previously if you provided a config like
projects: ['./tsconfig.json', './**/tsconfig.json'], then we would resolve this to./tsconfig.jsonandtsconfig.json, then later canonicalise them.This meant we'd check that same tsconfig twice!
By hoisting the canonicalisation, we can deduplicate this early.
Fixes #2814