Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [restrict-plus-operands] consider template literal types as strings

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 29, 2021

Fixes #3220.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Mar 29, 2021

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #3234 (1416848) into master (5414bf2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3234   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files         316      316           
  Lines       10851    10852    +1     
  Branches     3067     3068    +1     
=======================================
+ Hits        10084    10085    +1     
  Misses        342      342           
  Partials      425      425           
Flag Coverage Δ
unittest 92.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/restrict-plus-operands.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher added the bug label Mar 29, 2021
@JoshuaKGoldberg JoshuaKGoldberg requested a review from bradzacher Apr 5, 2021
Copy link
Member

@bradzacher bradzacher left a comment

thanks for this!

@bradzacher bradzacher changed the title fix(eslint-plugin): consider template literal types as strings in restrict-plus-operands fix(eslint-plugin): [restrict-plus-operands] consider template literal types as strings Apr 5, 2021
@bradzacher bradzacher merged commit ccfd68e into typescript-eslint:master Apr 5, 2021
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the restrict-plus-operands-template-literal branch Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants