Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-type-assertion] correct bad fix for angle bracket assertion #3244

Merged
merged 1 commit into from Mar 29, 2021

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Mar 29, 2021

fixes #3196

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Mar 29, 2021

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #3244 (ae9c141) into master (5414bf2) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #3244      +/-   ##
==========================================
- Coverage   92.93%   92.91%   -0.02%     
==========================================
  Files         316      316              
  Lines       10851    10854       +3     
  Branches     3067     3069       +2     
==========================================
+ Hits        10084    10085       +1     
  Misses        342      342              
- Partials      425      427       +2     
Flag Coverage Δ
unittest 92.91% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts 92.30% <60.00%> (-2.36%) ⬇️

Copy link
Member

@bradzacher bradzacher left a comment

thanks for doing this!

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-unnecessary-type-assertion] correct removed token range fix(eslint-plugin): [no-unnecessary-type-assertion] correct bad fix for angle bracket assertion Mar 29, 2021
@bradzacher bradzacher merged commit 265a039 into typescript-eslint:master Mar 29, 2021
9 of 10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants