Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-shadow] fix static class method generics shadowing class generics #3393

Merged
merged 1 commit into from May 15, 2021

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented May 15, 2021

Fixes #2592

Unfortunately I think this is impossible to solve from the scope analysis side.. So I opted instead to just ignore it from the lint rule.

…owing class generics

Fixes #2592

Unfortunately I think this is impossible to solve from the scope analysis side.. So I opted instead to just ignore it from the lint rule.
@bradzacher bradzacher added the bug label May 15, 2021
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented May 15, 2021

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Loading

@bradzacher bradzacher enabled auto-merge (squash) May 15, 2021
@codecov
Copy link

@codecov codecov bot commented May 15, 2021

Codecov Report

Merging #3393 (b376649) into master (df7a0d6) will decrease coverage by 0.19%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #3393      +/-   ##
==========================================
- Coverage   92.85%   92.66%   -0.20%     
==========================================
  Files         318      318              
  Lines       11048    11088      +40     
  Branches     3128     3146      +18     
==========================================
+ Hits        10259    10275      +16     
- Misses        352      361       +9     
- Partials      437      452      +15     
Flag Coverage Δ
unittest 92.66% <40.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-shadow.ts 76.61% <40.00%> (-17.44%) ⬇️

Loading

@bradzacher bradzacher disabled auto-merge May 15, 2021
@bradzacher bradzacher merged commit b1e1c8a into master May 15, 2021
9 of 10 checks passed
Loading
@bradzacher bradzacher deleted the 2592-static-class-method-generic-shadowing branch May 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant