Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unsafe-*] special case handling for the empty map constructor with no generics #3394

merged 2 commits into from May 15, 2021


Copy link

@bradzacher bradzacher commented May 15, 2021

Fixes #2109

Sucks that it had to be this way, but oh well.

… map constructor with no generics

Fixes #2109

Sucks that it had to be this way, but oh well.
@bradzacher bradzacher added the bug label May 15, 2021
Copy link

@typescript-eslint typescript-eslint bot commented May 15, 2021

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.


@bradzacher bradzacher enabled auto-merge (squash) May 15, 2021
Copy link

@codecov codecov bot commented May 15, 2021

Codecov Report

Merging #3394 (5a8a19a) into master (37ec2c2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3394   +/-   ##
  Coverage   92.68%   92.68%           
  Files         318      318           
  Lines       11096    11100    +4     
  Branches     3150     3152    +2     
+ Hits        10284    10288    +4     
  Misses        361      361           
  Partials      451      451           
Flag Coverage Δ
unittest 92.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts 85.22% <ø> (ø)
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts 98.24% <ø> (ø) 92.96% <100.00%> (ø)
packages/eslint-plugin/src/util/types.ts 82.25% <100.00%> (+0.38%) ⬆️


@bradzacher bradzacher disabled auto-merge May 15, 2021
@bradzacher bradzacher merged commit cae4f4a into master May 15, 2021
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
@bradzacher bradzacher deleted the 2109-special-case-empty-map-unsafe-assignment branch Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant