Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): add support for getter/setter signatures on types #3427

merged 2 commits into from May 22, 2021


Copy link

@bradzacher bradzacher commented May 22, 2021

Ref #3272

Copy link

@typescript-eslint typescript-eslint bot commented May 22, 2021

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.


Copy link

@codecov codecov bot commented May 22, 2021

Codecov Report

Merging #3427 (2687d43) into master (02acc4f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3427      +/-   ##
- Coverage   92.68%   92.67%   -0.02%     
  Files         318      318              
  Lines       11100    11109       +9     
  Branches     3152     3155       +3     
+ Hits        10288    10295       +7     
- Misses        361      362       +1     
- Partials      451      452       +1     
Flag Coverage Δ
unittest 92.67% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/dot-notation.ts 92.59% <ø> (ø) 100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts 98.26% <100.00%> (+0.02%) ⬆️
packages/eslint-plugin/src/util/types.ts 81.18% <0.00%> (-1.08%) ⬇️


Base automatically changed from 3272-update-ts-to-4.3-rc to master May 22, 2021
@bradzacher bradzacher merged commit b830b7f into master May 22, 2021
10 checks passed
@bradzacher bradzacher deleted the separate-write-types-on-properties branch May 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant