Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast-spec): extract AssignmentOperatorToText #3570

Merged
merged 3 commits into from Jun 13, 2022

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jun 21, 2021

This also makes AssignmentExpression's operator more type-safe whenever there would be a new AssignmentOperator

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jun 21, 2021

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

// @ts-expect-error: purposely unused
type _Test = {
readonly [T in AssignmentOperator]: AssignmentOperatorToText[T];
// If there are any AssignmentOperator members that don't have a corresponding
Copy link
Contributor Author

@MichaelDeBoey MichaelDeBoey Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in #3529

Comment needed to be added after readonly line because of prettier/prettier#11098

@nx-cloud
Copy link

nx-cloud bot commented Jun 21, 2021

☁️ Nx Cloud Report

CI is running/has finished running commands for commit df51533. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 47 targets

Sent with 💌 from NxCloud.

@bradzacher
Copy link
Member

bradzacher commented Jul 31, 2021

awaiting updates to #3623

@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party blocked by another PR PRs which are ready to go but waiting on another PR labels Jul 31, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the patch-20 branch 5 times, most recently from 1184ebf to 4d26407 Compare Aug 2, 2021
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Aug 2, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the patch-20 branch 2 times, most recently from 872d436 to 8e4c873 Compare Aug 21, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the patch-20 branch 2 times, most recently from 4798a51 to 2eed6c5 Compare Sep 8, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the patch-20 branch 3 times, most recently from 872cc6d to 4985516 Compare Sep 22, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the patch-20 branch 3 times, most recently from 138b4fc to e2707e9 Compare Oct 8, 2021
@MichaelDeBoey MichaelDeBoey dismissed a stale review via 1b7a99e Oct 29, 2021
@bradzacher bradzacher marked this pull request as draft Jan 17, 2022
@netlify
Copy link

netlify bot commented Feb 1, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit df51533
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62a68c34dbea3e00090286f1
😎 Deploy Preview https://deploy-preview-3570--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #3570 (c4bfb07) into main (b67b6e4) will increase coverage by 0.37%.
The diff coverage is n/a.

Current head c4bfb07 differs from pull request most recent head df51533. Consider uploading reports for the commit df51533 to get more accurate results

@@            Coverage Diff             @@
##             main    #3570      +/-   ##
==========================================
+ Coverage   91.33%   91.70%   +0.37%     
==========================================
  Files         132      363     +231     
  Lines        1488    12205   +10717     
  Branches      224     3541    +3317     
==========================================
+ Hits         1359    11193    +9834     
- Misses         65      662     +597     
- Partials       64      350     +286     
Flag Coverage Δ
unittest 91.70% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/parameter-properties.ts 94.11% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Referencer.ts 100.00% <0.00%> (ø)
...s/utils/src/ast-utils/eslint-utils/astUtilities.ts 100.00% <0.00%> (ø)
...s/eslint-plugin/src/util/collectUnusedVariables.ts 93.19% <0.00%> (ø)
packages/eslint-plugin/src/util/escapeRegExp.ts 75.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-namespace.ts 100.00% <0.00%> (ø)
...nt-plugin/src/rules/lines-between-class-members.ts 92.85% <0.00%> (ø)
...es/eslint-plugin/src/rules/object-curly-spacing.ts 100.00% <0.00%> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/util/astUtils.ts 83.33% <0.00%> (ø)
... and 221 more

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Mar 4, 2022

@bradzacher Since #3623 is closed, I guess we can merge this one? 🤔

@bradzacher bradzacher removed the blocked by another PR PRs which are ready to go but waiting on another PR label May 18, 2022
bradzacher
bradzacher previously approved these changes Jun 13, 2022
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks!

@bradzacher bradzacher changed the title fix(ast-spec): extract AssignmentOperatorToText feat(ast-spec): extract AssignmentOperatorToText Jun 13, 2022
@bradzacher bradzacher enabled auto-merge (squash) Jun 13, 2022
@bradzacher bradzacher disabled auto-merge Jun 13, 2022
@bradzacher bradzacher merged commit 45f75e6 into typescript-eslint:main Jun 13, 2022
37 checks passed
@MichaelDeBoey MichaelDeBoey deleted the patch-20 branch Jun 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants