Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-redeclare] ignoreDeclarationMerge of enum+namespace #3572

Merged

Conversation

idan-at
Copy link
Contributor

@idan-at idan-at commented Jun 21, 2021

…mespace

Closes #3568

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jun 21, 2021

Thanks for the PR, @idan-at!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jun 21, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit 916a666.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@idan-at
Copy link
Contributor Author

idan-at commented Jun 23, 2021

@bradzacher mind taking a quick look?

@bradzacher
Copy link
Member

bradzacher commented Jun 23, 2021

Please don't tag us. Your PR is in the queue. We volunteer to work on this in our personal time - we will review it when we have the time.

https://github.com/typescript-eslint/typescript-eslint/blob/master/CONTRIBUTING.md#addressing-feedback-and-beyond

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #3572 (916a666) into master (44c583a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3572   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         326      326           
  Lines       11253    11263   +10     
  Branches     3171     3173    +2     
=======================================
+ Hits        10425    10435   +10     
  Misses        368      368           
  Partials      460      460           
Flag Coverage Δ
unittest 92.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-redeclare.ts 92.00% <100.00%> (+1.23%) ⬆️

@bradzacher bradzacher changed the title feat(eslint-plugin): [no-redeclare] ignoreDeclarationMerge of enum+na… feat(eslint-plugin): [no-redeclare] ignoreDeclarationMerge of enum+namespace Jul 31, 2021
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for this!

@bradzacher bradzacher merged commit 18e30cb into typescript-eslint:master Jul 31, 2021
11 checks passed
@idan-at idan-at deleted the no-redeclare-enum-namespace branch Aug 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants