Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): simplify eslint-utils' findVariable's signature in ast-utils #3574

Merged
merged 1 commit into from Jul 31, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jun 22, 2021

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jun 22, 2021

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jun 22, 2021

Nx Cloud Report

CI is running for commit 678b15a.

📂 Click to track the progress, see the status, the terminal output, and the build insights.


Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #3574 (678b15a) into master (84fff35) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3574      +/-   ##
==========================================
- Coverage   92.64%   92.52%   -0.12%     
==========================================
  Files         326      187     -139     
  Lines       11253     8393    -2860     
  Branches     3171     2580     -591     
==========================================
- Hits        10425     7766    -2659     
+ Misses        368      261     -107     
+ Partials      460      366      -94     
Flag Coverage Δ
unittest 92.52% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-utils/src/ast-utils/eslint-utils/scopeAnalysis.ts 100.00% <ø> (ø)
packages/scope-manager/src/scope/FunctionScope.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/typescript-estree/src/node-utils.ts
...kages/scope-manager/src/scope/FunctionTypeScope.ts
...ckages/scope-manager/src/referencer/TypeVisitor.ts
packages/scope-manager/src/referencer/Reference.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
packages/scope-manager/src/lib/es2017.ts
packages/scope-manager/src/variable/index.ts
... and 130 more

Copy link
Member

@bradzacher bradzacher left a comment

thanks!

@bradzacher bradzacher added the bug Something isn't working label Jul 31, 2021
@bradzacher bradzacher merged commit 3ef5267 into typescript-eslint:master Jul 31, 2021
10 checks passed
@MichaelDeBoey MichaelDeBoey deleted the patch-21 branch Jul 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants