Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): Catch unused React import with new JSX transform #3577

Merged

Conversation

lexanth
Copy link
Contributor

@lexanth lexanth commented Jun 24, 2021

Fixes #3303

Using null for this is consistent with the jsxFragmentPragma, but is a bit strange. However, I think it does match the intention of the new JSX transform - pushing it into the build system so that it is invisible in source code (so null is reasonable).

@bradzacher bradzacher added the enhancement New feature or request label Jul 31, 2021
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for doing this!

@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #3577 (3ee3880) into master (3ef5267) will increase coverage by 0.12%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #3577      +/-   ##
==========================================
+ Coverage   92.52%   92.64%   +0.12%     
==========================================
  Files         188      327     +139     
  Lines        8464    11335    +2871     
  Branches     2602     3196     +594     
==========================================
+ Hits         7831    10501    +2670     
- Misses        263      370     +107     
- Partials      370      464      +94     
Flag Coverage Δ
unittest 92.64% <50.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/analyze.ts 66.66% <50.00%> (ø)
...ackages/scope-manager/src/referencer/Referencer.ts 93.90% <50.00%> (ø)
packages/scope-manager/src/lib/es2019.symbol.ts 100.00% <0.00%> (ø)
...ges/scope-manager/src/definition/DefinitionBase.ts 100.00% <0.00%> (ø)
...ages/scope-manager/src/lib/esnext.asynciterable.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/esnext.promise.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2021.weakref.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2015.proxy.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/esnext.array.ts 100.00% <0.00%> (ø)
... and 131 more

@bradzacher bradzacher merged commit 02998ea into typescript-eslint:master Aug 1, 2021
10 of 11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants