Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-implied-eval] handle bind on nested member expressions #3598

Merged
merged 3 commits into from Jul 31, 2021

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Jun 30, 2021

Fixes #3582

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jun 30, 2021

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #3598 (f62c837) into master (75dcf69) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3598   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         326      326           
  Lines       11253    11255    +2     
  Branches     3171     3173    +2     
=======================================
+ Hits        10425    10427    +2     
  Misses        368      368           
  Partials      460      460           
Flag Coverage Δ
unittest 92.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 93.93% <100.00%> (+0.18%) ⬆️

@nx-cloud
Copy link

nx-cloud bot commented Jun 30, 2021

Nx Cloud Report

CI ran the following commands for commit f62c837. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Jun 30, 2021

Nx Cloud Report

CI ran the following commands for commit 4987a1c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the bug Something isn't working label Jul 6, 2021
Copy link
Member

@bradzacher bradzacher left a comment

thanks for fixing this!

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-implied-eval] handle bind fix(eslint-plugin): [no-implied-eval] handle bind on nested member expressions Jul 31, 2021
@bradzacher bradzacher merged commit f5a6806 into typescript-eslint:master Jul 31, 2021
11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants