Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [return-await] handle nested functions correctly #3601

Conversation

MichaelBelousov
Copy link
Contributor

@MichaelBelousov MichaelBelousov commented Jul 2, 2021

fix for #3600

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jul 2, 2021

Thanks for the PR, @MichaelBelousov!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jul 2, 2021

Nx Cloud Report

CI ran the following commands for commit 8b1f4c5. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@MichaelBelousov MichaelBelousov changed the title [return-await] handle nested functions correctly fix: [return-await] handle nested functions correctly Jul 2, 2021
@MichaelBelousov
Copy link
Contributor Author

MichaelBelousov commented Jul 6, 2021

@bradzacher is the apparent Nx Cloud Report something that is blocking this PR?

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #3601 (8b1f4c5) into master (f2c078c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3601      +/-   ##
==========================================
+ Coverage   92.64%   92.65%   +0.01%     
==========================================
  Files         326      326              
  Lines       11253    11255       +2     
  Branches     3171     3171              
==========================================
+ Hits        10425    10428       +3     
  Misses        368      368              
+ Partials      460      459       -1     
Flag Coverage Δ
unittest 92.65% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/return-await.ts 96.96% <100.00%> (+1.09%) ⬆️

@MichaelBelousov
Copy link
Contributor Author

MichaelBelousov commented Jul 8, 2021

@bradzacher sorry for bothering, but it's been silent so I don't know where we're at with this one. Is this slated for review?

@bradzacher bradzacher changed the title fix: [return-await] handle nested functions correctly fix(eslint-plugin): [return-await] handle nested functions correctly Jul 31, 2021
@bradzacher bradzacher added the bug Something isn't working label Jul 31, 2021
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for fixing this!

@bradzacher bradzacher merged commit 4a196b5 into typescript-eslint:master Jul 31, 2021
11 checks passed
@bradzacher bradzacher linked an issue Jul 31, 2021 that may be closed by this pull request
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants