Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-implied-eval] permit more expression types #3624

Merged
merged 2 commits into from Aug 1, 2021

Conversation

jas14
Copy link
Contributor

@jas14 jas14 commented Jul 10, 2021

Fixes #3621.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jul 10, 2021

Thanks for the PR, @jas14!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #3624 (eef56d4) into master (9750c6f) will increase coverage by 0.89%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3624      +/-   ##
==========================================
+ Coverage   92.68%   93.57%   +0.89%     
==========================================
  Files         327      147     -180     
  Lines       11348     7862    -3486     
  Branches     3199     2489     -710     
==========================================
- Hits        10518     7357    -3161     
+ Misses        369      161     -208     
+ Partials      461      344     -117     
Flag Coverage Δ
unittest 93.57% <100.00%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 93.93% <100.00%> (ø)
packages/scope-manager/src/analyze.ts
...kages/scope-manager/src/lib/es2020.sharedmemory.ts
packages/typescript-estree/src/convert-comments.ts
packages/scope-manager/src/scope/ScopeType.ts
packages/visitor-keys/src/get-keys.ts
packages/visitor-keys/src/visitor-keys.ts
...kages/experimental-utils/src/eslint-utils/index.ts
packages/experimental-utils/src/ast-utils/index.ts
packages/scope-manager/src/lib/es2018.ts
... and 171 more

@bradzacher bradzacher added the bug Something isn't working label Jul 31, 2021
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for doing this!

@bradzacher bradzacher changed the title fix(eslint-plugin): permit more expression types for no-implied-eval (#3621) fix(eslint-plugin): [no-implied-eval] permit more expression types Aug 1, 2021
@bradzacher bradzacher merged commit ca7c549 into typescript-eslint:master Aug 1, 2021
11 checks passed
@jas14 jas14 deleted the no-implied-eval-fix branch Aug 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants