Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [return-await] properly handle fixes for TSAsExpression #3631

Merged
merged 2 commits into from Aug 1, 2021

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Jul 12, 2021

Fixes #3613.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jul 12, 2021

Thanks for the PR, @rafaelss95!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #3631 (a9a6f2c) into master (62bcc93) will increase coverage by 0.89%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3631      +/-   ##
==========================================
+ Coverage   92.68%   93.57%   +0.89%     
==========================================
  Files         325      147     -178     
  Lines       11342     7864    -3478     
  Branches     3200     2490     -710     
==========================================
- Hits        10512     7359    -3153     
+ Misses        369      161     -208     
+ Partials      461      344     -117     
Flag Coverage Δ
unittest 93.57% <100.00%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/return-await.ts 97.02% <100.00%> (+0.06%) ⬆️
packages/scope-manager/src/lib/es2016.full.ts
packages/typescript-estree/src/node-utils.ts
...es/experimental-utils/src/ts-eslint-scope/Scope.ts
...scope-manager/src/definition/VariableDefinition.ts
...ackages/scope-manager/src/referencer/Referencer.ts
packages/scope-manager/src/lib/es2019.ts
packages/scope-manager/src/lib/index.ts
packages/scope-manager/src/scope/FunctionScope.ts
...ges/typescript-estree/src/create-program/shared.ts
... and 169 more

@nx-cloud
Copy link

nx-cloud bot commented Jul 12, 2021

Nx Cloud Report

CI ran the following commands for commit af42325. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the bug Something isn't working label Jul 31, 2021
bradzacher
bradzacher previously approved these changes Jul 31, 2021
Copy link
Member

@bradzacher bradzacher left a comment

thanks for fixing this!

Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for fixing tihs!

@bradzacher bradzacher merged commit 00a4369 into typescript-eslint:master Aug 1, 2021
11 checks passed
@rafaelss95 rafaelss95 deleted the fix/3613 branch Aug 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants