Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): extract isNodeOfType out of ast-utils' predicates #3677

Merged
merged 1 commit into from Sep 3, 2021

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Aug 1, 2021

Just like I did in testing-library/eslint-plugin-testing-library#329

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Aug 1, 2021

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Loading

@codecov
Copy link

@codecov codecov bot commented Aug 1, 2021

Codecov Report

Merging #3677 (caa6f22) into master (a752638) will decrease coverage by 0.05%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #3677      +/-   ##
==========================================
- Coverage   92.68%   92.63%   -0.06%     
==========================================
  Files         327      188     -139     
  Lines       11351     8483    -2868     
  Branches     3201     2603     -598     
==========================================
- Hits        10521     7858    -2663     
+ Misses        369      258     -111     
+ Partials      461      367      -94     
Flag Coverage Δ
unittest 92.63% <87.50%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/experimental-utils/src/ast-utils/predicates.ts 46.66% <87.50%> (+9.82%) ⬆️
...src/definition/ImplicitGlobalVariableDefinition.ts
...e-manager/src/scope/FunctionExpressionNameScope.ts
packages/scope-manager/src/lib/es2019.symbol.ts
...ges/scope-manager/src/definition/TypeDefinition.ts
packages/scope-manager/src/scope/TSEnumScope.ts
...ackages/scope-manager/src/referencer/Referencer.ts
packages/scope-manager/src/lib/dom.iterable.ts
...ages/scope-manager/src/lib/esnext.asynciterable.ts
packages/scope-manager/src/lib/es2017.string.ts
... and 130 more

Loading

Copy link
Member

@bradzacher bradzacher left a comment

thanks!

Loading

@bradzacher bradzacher merged commit 4bfa437 into typescript-eslint:master Sep 3, 2021
10 of 11 checks passed
Loading
@MichaelDeBoey MichaelDeBoey deleted the patch-21 branch Sep 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants