Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): isTypeReadonly error with <TS3.7 #3731

Conversation

@RebeccaStevens
Copy link
Contributor

@RebeccaStevens RebeccaStevens commented Aug 13, 2021

No description provided.

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Aug 13, 2021

Thanks for the PR, @RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Loading

@codecov
Copy link

@codecov codecov bot commented Aug 13, 2021

Codecov Report

Merging #3731 (8727289) into master (db78642) will increase coverage by 0.86%.
The diff coverage is 33.33%.

Current head 8727289 differs from pull request most recent head a6c3bad. Consider uploading reports for the commit a6c3bad to get more accurate results

@@            Coverage Diff             @@
##           master    #3731      +/-   ##
==========================================
+ Coverage   92.68%   93.55%   +0.86%     
==========================================
  Files         327      147     -180     
  Lines       11351     7866    -3485     
  Branches     3201     2492     -709     
==========================================
- Hits        10521     7359    -3162     
+ Misses        369      162     -207     
+ Partials      461      345     -116     
Flag Coverage Δ
unittest 93.55% <33.33%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/util/isTypeReadonly.ts 94.20% <33.33%> (-2.82%) ⬇️
...rimental-utils/src/ts-eslint-scope/ScopeManager.ts
...es/experimental-utils/src/ts-eslint-scope/index.ts
...ges/experimental-utils/src/ast-utils/predicates.ts
packages/scope-manager/src/lib/es2020.promise.ts
packages/experimental-utils/src/json-schema.ts
packages/scope-manager/src/lib/es2018.promise.ts
...mental-utils/src/ts-eslint-scope/PatternVisitor.ts
packages/typescript-estree/src/ast-converter.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
... and 171 more

Loading

Copy link
Member

@bradzacher bradzacher left a comment

thanks for fixing this!

Loading

@bradzacher bradzacher merged commit 5696407 into typescript-eslint:master Aug 30, 2021
10 of 11 checks passed
Loading
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants