Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(visitor-keys): add key to StaticBlock #3812

Merged
merged 1 commit into from Aug 29, 2021

Conversation

@ota-meshi
Copy link
Contributor

@ota-meshi ota-meshi commented Aug 29, 2021

This PR is for version 5.

I noticed that didn't have StaticBlock visitor keys so I added it.

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Aug 29, 2021

Thanks for the PR, @ota-meshi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Loading

@bradzacher bradzacher changed the base branch from v5 to master Aug 29, 2021
@bradzacher bradzacher dismissed MichaelDeBoey’s stale review Aug 29, 2021

The base branch was changed.

@bradzacher bradzacher changed the base branch from master to v5 Aug 29, 2021
Copy link
Member

@bradzacher bradzacher left a comment

this should actually be made against master as StaticBlock was merged into master.
can you rebase your PR against master so we can get this out with the release monday?

Loading

@ota-meshi ota-meshi changed the base branch from v5 to master Aug 29, 2021
@ota-meshi ota-meshi changed the title fix(visitor-keys): add key to StaticBlock (v5) fix(visitor-keys): add key to StaticBlock Aug 29, 2021
@ota-meshi
Copy link
Contributor Author

@ota-meshi ota-meshi commented Aug 29, 2021

I was misunderstanding 😅 I changed this PR.

Loading

@codecov
Copy link

@codecov codecov bot commented Aug 29, 2021

Codecov Report

Merging #3812 (1b0e00d) into master (055add0) will increase coverage by 0.77%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3812      +/-   ##
==========================================
+ Coverage   92.68%   93.46%   +0.77%     
==========================================
  Files         327      147     -180     
  Lines       11351     7819    -3532     
  Branches     3201     2476     -725     
==========================================
- Hits        10521     7308    -3213     
+ Misses        369      175     -194     
+ Partials      461      336     -125     
Flag Coverage Δ
unittest 93.46% <100.00%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/src/rules/indent-new-do-not-use/OffsetStorage.ts 100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-extra-semi.ts 66.66% <0.00%> (-33.34%) ⬇️
...s/eslint-plugin/src/rules/no-dupe-class-members.ts 87.50% <0.00%> (-12.50%) ⬇️
...es/eslint-plugin/src/rules/no-loss-of-precision.ts 83.33% <0.00%> (-8.34%) ⬇️
packages/eslint-plugin/src/util/types.ts 74.19% <0.00%> (-6.99%) ⬇️
...es/eslint-plugin/src/rules/no-duplicate-imports.ts 95.65% <0.00%> (-2.13%) ⬇️
packages/eslint-plugin/src/rules/typedef.ts 96.05% <0.00%> (ø)
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 76.61% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-namespace.ts 100.00% <0.00%> (ø)
... and 276 more

Loading

@ota-meshi ota-meshi requested a review from bradzacher Aug 29, 2021
@bradzacher
Copy link
Member

@bradzacher bradzacher commented Aug 29, 2021

Thanks!

Loading

@bradzacher bradzacher merged commit fa35e22 into typescript-eslint:master Aug 29, 2021
13 checks passed
Loading
@ota-meshi ota-meshi deleted the fix branch Aug 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants