isNodeOfTypeWithConditions out of
Thanks for the PR, @MichaelDeBoey!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
@@ Coverage Diff @@ ## master #3837 +/- ## ========================================== - Coverage 93.51% 92.65% -0.87% ========================================== Files 151 192 +41 Lines 8144 8767 +623 Branches 2584 2694 +110 ========================================== + Hits 7616 8123 +507 - Misses 167 260 +93 - Partials 361 384 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
@bradzacher We're really talking about fractions over here.
The big benefit is that you don't have to declare the same thing in both return type and check, which for me is a big win in DX.
In isolation - yes, but these functions can be called thousands of times each over a codebase - which can add up very quickly.
Let's move the
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.