Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [prefer-return-this-type] handle generics properly in fixer #3852

Merged
merged 2 commits into from Sep 21, 2021

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Sep 7, 2021

Fixes #3842.

@typescript-eslint
Copy link
Contributor

@typescript-eslint typescript-eslint bot commented Sep 7, 2021

Thanks for the PR, @rafaelss95!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@rafaelss95 rafaelss95 changed the title fix(eslint-plugin): [prefer-return-this-type]: handle generics propery in fixer fix(eslint-plugin): [prefer-return-this-type]: handle generics properly in fixer Sep 7, 2021
@codecov
Copy link

@codecov codecov bot commented Sep 7, 2021

Codecov Report

Merging #3852 (a937297) into master (4195919) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3852      +/-   ##
==========================================
- Coverage   93.50%   93.50%   -0.01%     
==========================================
  Files         151      151              
  Lines        8134     8132       -2     
  Branches     2580     2579       -1     
==========================================
- Hits         7606     7604       -2     
  Misses        167      167              
  Partials      361      361              
Flag Coverage Δ
unittest 93.50% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eslint-plugin/src/rules/prefer-return-this-type.ts 90.16% <100.00%> (-0.32%) ⬇️

@bradzacher bradzacher added the bug label Sep 7, 2021
MichaelDeBoey
MichaelDeBoey previously approved these changes Sep 8, 2021
@rafaelss95 rafaelss95 changed the title fix(eslint-plugin): [prefer-return-this-type]: handle generics properly in fixer fix(eslint-plugin): [prefer-return-this-type] handle generics properly in fixer Sep 12, 2021
@rafaelss95 rafaelss95 force-pushed the fix/3842 branch 2 times, most recently from e6199a8 to 4a3a163 Compare Sep 12, 2021
Copy link
Member

@bradzacher bradzacher left a comment

thanks for this! - one comment

const node =
classNameRef.parent?.type === AST_NODE_TYPES.TSTypeReference
? classNameRef.parent
: classNameRef;
Copy link
Member

@bradzacher bradzacher Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of doing this here - we should instead change the tryGetNameInType function to return the TSTypeReference instead of the Identifier.

@bradzacher bradzacher added the awaiting response label Sep 20, 2021
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for fixing this!

@bradzacher bradzacher removed the awaiting response label Sep 21, 2021
@bradzacher bradzacher merged commit 9e98b8f into typescript-eslint:master Sep 21, 2021
11 checks passed
@rafaelss95 rafaelss95 deleted the fix/3842 branch Sep 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants