Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-var-requires] report problems within NewExpression #3884

Merged
merged 1 commit into from Sep 20, 2021

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Sep 14, 2021

Fixes #3883.

@typescript-eslint
Copy link
Contributor

@typescript-eslint typescript-eslint bot commented Sep 14, 2021

Thanks for the PR, @rafaelss95!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Sep 14, 2021

Codecov Report

Merging #3884 (c9b53f2) into master (b1df817) will increase coverage by 0.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3884      +/-   ##
==========================================
+ Coverage   92.70%   93.53%   +0.82%     
==========================================
  Files         329      149     -180     
  Lines       11534     8043    -3491     
  Branches     3257     2550     -707     
==========================================
- Hits        10693     7523    -3170     
+ Misses        368      164     -204     
+ Partials      473      356     -117     
Flag Coverage Δ
unittest 93.53% <ø> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-var-requires.ts 88.88% <ø> (ø)
...ages/scope-manager/src/referencer/ExportVisitor.ts
packages/scope-manager/src/lib/es2018.full.ts
packages/scope-manager/src/lib/es2016.full.ts
...ges/experimental-utils/src/ast-utils/predicates.ts
packages/scope-manager/src/definition/index.ts
packages/scope-manager/src/lib/es2019.array.ts
packages/scope-manager/src/lib/es2019.symbol.ts
packages/typescript-estree/src/convert.ts
...ages/scope-manager/src/lib/es2016.array.include.ts
... and 171 more

@bradzacher bradzacher added the bug label Sep 14, 2021
Copy link
Member

@bradzacher bradzacher left a comment

thanks for fixing this!

@bradzacher bradzacher merged commit ed5e459 into typescript-eslint:master Sep 20, 2021
11 checks passed
@rafaelss95 rafaelss95 deleted the fix/3883 branch Sep 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants