Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin-internal): [prefer-ast-types-enum] add DefinitionType enum #3916

merged 2 commits into from Sep 21, 2021


Copy link

As per discussion on #3868 (comment)

Copy link

Thanks for the PR, @rafaelss95!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #3916 (ccd20cd) into master (8aa87a1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3916   +/-   ##
  Coverage   93.51%   93.51%           
  Files         151      151           
  Lines        8141     8146    +5     
  Branches     2583     2583           
+ Hits         7613     7618    +5     
  Misses        167      167           
  Partials      361      361           
Flag Coverage Δ
unittest 93.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 93.33% <ø> (ø)
...nt-plugin/src/rules/no-unused-vars-experimental.ts 91.39% <ø> (ø)
...plugin/src/rules/explicit-module-boundary-types.ts 89.47% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 77.34% <100.00%> (+0.73%) ⬆️
packages/eslint-plugin/src/rules/no-type-alias.ts 100.00% <100.00%> (ø) 91.20% <100.00%> (+0.09%) ⬆️

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Sep 21, 2021
bradzacher previously approved these changes Sep 21, 2021
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for making this codebase cleaner!!

@bradzacher bradzacher enabled auto-merge (squash) September 21, 2021 06:56
@bradzacher bradzacher merged commit 13b7de5 into typescript-eslint:master Sep 21, 2021
10 checks passed
@rafaelss95 rafaelss95 deleted the feat/internal branch September 21, 2021 11:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants