Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-confusing-void-expression] support optional chaining #3937

Merged
merged 2 commits into from Oct 3, 2021

Conversation

undsoft
Copy link
Contributor

@undsoft undsoft commented Sep 29, 2021

Fixes: #3454

@typescript-eslint
Copy link
Contributor

@typescript-eslint typescript-eslint bot commented Sep 29, 2021

Thanks for the PR, @undsoft!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Sep 29, 2021

Codecov Report

Merging #3937 (39f6554) into master (02c6ff3) will increase coverage by 0.81%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3937      +/-   ##
==========================================
+ Coverage   92.70%   93.51%   +0.81%     
==========================================
  Files         331      151     -180     
  Lines       11637     8145    -3492     
  Branches     3290     2583     -707     
==========================================
- Hits        10788     7617    -3171     
+ Misses        371      167     -204     
+ Partials      478      361     -117     
Flag Coverage Δ
unittest 93.51% <100.00%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-plugin/src/rules/no-confusing-void-expression.ts 98.85% <100.00%> (+0.02%) ⬆️
packages/typescript-estree/src/ast-converter.ts
...ges/scope-manager/src/lib/es2018.asyncgenerator.ts
...e-manager/src/definition/FunctionNameDefinition.ts
packages/experimental-utils/src/ast-utils/misc.ts
...xperimental-utils/src/eslint-utils/applyDefault.ts
packages/scope-manager/src/analyze.ts
packages/scope-manager/src/lib/es2019.string.ts
...ckages/scope-manager/src/referencer/TypeVisitor.ts
...ages/scope-manager/src/referencer/ImportVisitor.ts
... and 171 more

@bradzacher bradzacher added the bug label Oct 3, 2021
Copy link
Member

@bradzacher bradzacher left a comment

thanks for fixing this!

@bradzacher bradzacher changed the title fix(eslint-plugin): Optional chaining in no-confusing-void-expression fix(eslint-plugin): [no-confusing-void-expression] support optional chaining Oct 3, 2021
@bradzacher bradzacher merged commit c40dd13 into typescript-eslint:master Oct 3, 2021
11 checks passed
@undsoft undsoft deleted the eslint-plugin-chaining branch Oct 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants