New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [prefer-regexp-exec] check RegExp
without flags
#3946
Conversation
Thanks for the PR, @rafaelss95! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! |
Codecov Report
@@ Coverage Diff @@
## master #3946 +/- ##
==========================================
+ Coverage 92.70% 93.51% +0.81%
==========================================
Files 331 151 -180
Lines 11637 8143 -3494
Branches 3290 2582 -708
==========================================
- Hits 10788 7615 -3173
+ Misses 371 167 -204
+ Partials 478 361 -117
Flags with carried forward coverage won't be shown. Click here to find out more. |
1 similar comment
Nx Cloud ReportCI ran the following commands for commit 1fabb13. Click to see the status, the terminal output, and the build insights.
Sent with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bitten by the non-nullish array types :(
thanks for fixing this!
Yes, |
Fixes #3941.