Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): require fix in suggestions #3949

Merged
merged 1 commit into from Oct 3, 2021

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Oct 2, 2021

Fixes #3948

Every suggestion must have a fix function, it can't be left empty (nullish).

I did a similar fix in eslint's types recently. Really they should be aligned IMO but it seems they're already diverged anyway.

@typescript-eslint
Copy link
Contributor

@typescript-eslint typescript-eslint bot commented Oct 2, 2021

Thanks for the PR, @43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Oct 2, 2021

Codecov Report

Merging #3949 (6135baf) into master (02c6ff3) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3949      +/-   ##
==========================================
- Coverage   92.70%   92.60%   -0.10%     
==========================================
  Files         331      192     -139     
  Lines       11637     8765    -2872     
  Branches     3290     2696     -594     
==========================================
- Hits        10788     8117    -2671     
+ Misses        371      264     -107     
+ Partials      478      384      -94     
Flag Coverage Δ
unittest 92.60% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/index.ts
packages/scope-manager/src/scope/ModuleScope.ts
...t-estree/src/create-program/useProvidedPrograms.ts
packages/scope-manager/src/lib/es2018.intl.ts
packages/scope-manager/src/lib/esnext.ts
packages/typescript-estree/src/ts-estree/index.ts
packages/scope-manager/src/lib/es2019.string.ts
...ackages/scope-manager/src/lib/es2015.collection.ts
packages/scope-manager/src/lib/base-config.ts
packages/typescript-estree/src/simple-traverse.ts
... and 129 more

@bradzacher bradzacher added the bug label Oct 3, 2021
Copy link
Member

@bradzacher bradzacher left a comment

thanks for helping keep the types in sync!

@bradzacher bradzacher merged commit f022fb1 into typescript-eslint:master Oct 3, 2021
11 checks passed
@43081j 43081j deleted the require-fix branch Oct 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants